Skip to main content

Pull Request And Code reviews

  • We are following google engineering best practices

https://github.com/google/eng-practices

Terminology​

There is some Google-internal terminology used in some of these documents, which we clarify here for external readers:

CL: Stands for "changelist," which means one self-contained change that has been submitted to version control or which is undergoing code review. Other organizations often call this a "change" or a "patch."

LGTM: Means "Looks Good to Me." It is what a code reviewer says when approving a CL.

Good practices on pull request creation => https://github.com/google/eng-practices/blob/master/review/developer/index.md

How to do a good code review => https://github.com/google/eng-practices/blob/master/review/reviewer/index.md